Conversation
galargh
commented
Aug 14, 2025
| node-version: lts/* | ||
| cache: npm | ||
| - run: npm ci | ||
| - uses: ipfs/aegir/actions/cache-node-modules@main |
Contributor
Author
There was a problem hiding this comment.
Thanks to this, we'll retrieve the build from cache. If, for some reason, cached build is not available, we'll run npm run build.
galargh
commented
Aug 14, 2025
| runs-on: ubuntu-latest | ||
| needs: js-test-and-release | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | ||
| if: needs.js-test-and-release.outputs.release == 'true' |
Contributor
Author
There was a problem hiding this comment.
I exposed this output in https://github.com/ipdxco/unified-github-workflows/releases/tag/v1.0.30
galargh
commented
Aug 14, 2025
| "build": "npm run sync-version && tsc && cp src/manifest.json dist/ && cp src/popup.html dist/ && cp -r src/icons dist/", | ||
| "package": "npm run build && web-ext build --source-dir=dist --artifacts-dir=. --filename=ipfs-quicklaunch.zip --overwrite-dest", | ||
| "publish:chrome-store": "npx cws-publish $CHROME_CLIENT_ID $CHROME_CLIENT_SECRET $CHROME_REFRESH_TOKEN ipfs-quicklaunch.zip $CHROME_EXTENSION_ID", | ||
| "package": "web-ext build --source-dir=dist --artifacts-dir=. --filename=ipfs-quicklaunch.zip --overwrite-dest", |
Contributor
Author
There was a problem hiding this comment.
I removed build from here because we want to retrieve it from cache instead of running it during publishing.
2color
approved these changes
Aug 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=========================
=========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that we use the cached build for the publishing if available. The build should be cached when
js-test-and-releaseruns.This PR also introduces usage of the new
release(https://github.com/ipdxco/unified-github-workflows/releases/tag/v1.0.30) output of thejs-test-and-releasejob. The output indicates whether a release was attempted or not.